Skip to content

Conversation

elfosardo
Copy link
Member

Do not use this in production, yet!

This patch converts the 01_install_requirements.sh file from pure bash to use a mix of few bash commands and extensive ansible playbooks.
The initial conversion has been obtained using Cursor prompt using claude-4-sonnet model.
Lots of manual changes have been applied to be able to get a successful outcome, and more testing is needed to verify the entire worflow work as intended.

Do not use this in production, yet!

This patch converts the 01_install_requirements.sh file
from pure bash to use a mix of few bash commands and extensive
ansible playbooks.
The initial conversion has been obtained using Cursor prompt
using claude-4-sonnet model.
Lots of manual changes have been applied to be able to get
a successful outcome, and more testing is needed to verify
the entire worflow work as intended.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2025
Copy link

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign celebdor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo
Copy link
Member Author

/cc @dtantsur @tdomnesc @rhjanders

Copy link

openshift-ci bot commented Aug 21, 2025

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack ba9ec3b link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-agent-4control-ipv4 ba9ec3b link false /test e2e-agent-4control-ipv4
ci/prow/e2e-agent-bad-dns ba9ec3b link false /test e2e-agent-bad-dns
ci/prow/e2e-agent-compact-ipv4 ba9ec3b link true /test e2e-agent-compact-ipv4
ci/prow/e2e-agent-5control-ipv4 ba9ec3b link false /test e2e-agent-5control-ipv4
ci/prow/e2e-agent-sno-ipv6 ba9ec3b link false /test e2e-agent-sno-ipv6
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 ba9ec3b link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-agent-iso-no-registry-compact-ipv4 ba9ec3b link false /test e2e-agent-iso-no-registry-compact-ipv4
ci/prow/e2e-metal-ipi-ovn-ipv6 ba9ec3b link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-agent-ha-dualstack ba9ec3b link false /test e2e-agent-ha-dualstack
ci/prow/e2e-metal-ipi-virtualmedia ba9ec3b link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm ba9ec3b link true /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-bm-bond ba9ec3b link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ovn-arbiter ba9ec3b link false /test e2e-metal-ovn-arbiter
ci/prow/e2e-metal-ipi-serial-ipv4-2of2 ba9ec3b link true /test e2e-metal-ipi-serial-ipv4-2of2
ci/prow/e2e-metal-ipi-serial-ipv4-1of2 ba9ec3b link true /test e2e-metal-ipi-serial-ipv4-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


- name: Template daemon.json to /etc/docker/daemon.json
template:
src: "{{ DAEMON_JSON_PATH }}/daemon.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks weird.
Instead of a template, this lives under files, but we pass the path to it as an environment variable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yowza

Copy link
Member

@zaneb zaneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it me or is there waaay more Ansible here than what was happening in just 01_install_requirements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants