-
Notifications
You must be signed in to change notification settings - Fork 199
[WIP] Convert 01_install_requirements to ansible #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Do not use this in production, yet! This patch converts the 01_install_requirements.sh file from pure bash to use a mix of few bash commands and extensive ansible playbooks. The initial conversion has been obtained using Cursor prompt using claude-4-sonnet model. Lots of manual changes have been applied to be able to get a successful outcome, and more testing is needed to verify the entire worflow work as intended.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@elfosardo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
||
- name: Template daemon.json to /etc/docker/daemon.json | ||
template: | ||
src: "{{ DAEMON_JSON_PATH }}/daemon.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks weird.
Instead of a template, this lives under files, but we pass the path to it as an environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yowza
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it me or is there waaay more Ansible here than what was happening in just 01_install_requirements?
Do not use this in production, yet!
This patch converts the 01_install_requirements.sh file from pure bash to use a mix of few bash commands and extensive ansible playbooks.
The initial conversion has been obtained using Cursor prompt using claude-4-sonnet model.
Lots of manual changes have been applied to be able to get a successful outcome, and more testing is needed to verify the entire worflow work as intended.