Skip to content

Conversation

jupierce
Copy link
Contributor

Replaces more dnf invocations than #1785 with function.

@openshift-ci openshift-ci bot requested review from dtantsur and lranjbar August 19, 2025 20:08
Copy link

openshift-ci bot commented Aug 19, 2025

Hi @jupierce. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 19, 2025
@jupierce
Copy link
Contributor Author

/label ok-to-test

Copy link

openshift-ci bot commented Aug 19, 2025

@jupierce: The label(s) /label ok-to-test cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bfournie
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2025
@jupierce jupierce changed the title Add retries for external dependencies OCPBUGS-57386: Add retries for external dependencies Aug 19, 2025
@jupierce
Copy link
Contributor Author

/test e2e-metal-ipi-bm

Copy link

openshift-ci bot commented Aug 20, 2025

@jupierce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-iso-no-registry-compact-ipv4 fe17b36 link false /test e2e-agent-iso-no-registry-compact-ipv4
ci/prow/e2e-agent-bad-dns fe17b36 link false /test e2e-agent-bad-dns
ci/prow/e2e-metal-ipi-ovn-dualstack fe17b36 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 fe17b36 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
@andfasano
Copy link
Member

/approve

Copy link

openshift-ci bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2025
@andfasano
Copy link
Member

/hold

It looks like #1785 should land before the current one?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2025
@jupierce
Copy link
Contributor Author

@andfasano this pull request is a superset of #1785 and covers significantly more surface area. I didn't know which the team would be more comfortable with. #1785 is the minimum to address issues discussed in OCPBUGS-57386. This PR covers the same class of issues, but across more of the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants