Skip to content

CNF-15623:must-gather: add support for hypershift #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2025

Conversation

Tal-or
Copy link
Collaborator

@Tal-or Tal-or commented Mar 18, 2025

To support running MG on hosted clusters, we should check whether we're
running on standard OpenShift or HyperShift
and collect the relevant data accordingly.

Signed-off-by: Talor Itzhak [email protected]

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@openshift-ci openshift-ci bot requested review from ffromani and swatisehgal March 18, 2025 10:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@Tal-or
Copy link
Collaborator Author

Tal-or commented Mar 18, 2025

/hold
e2e tests are missing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2025
@Tal-or Tal-or changed the title WIP: must-gather: add support for hypershift WIP: CNF-15623:must-gather: add support for hypershift Mar 18, 2025
@openshift-ci-robot
Copy link

@Tal-or: This pull request references CNF-15623 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

To support running MG on hosted clusters, we should check whether we're
running on standard OpenShift or HyperShift
and collect the relevant data accordingly.

Signed-off-by: Talor Itzhak [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or Tal-or changed the title WIP: CNF-15623:must-gather: add support for hypershift CNF-15623:must-gather: add support for hypershift Mar 19, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025
@Tal-or
Copy link
Collaborator Author

Tal-or commented Mar 19, 2025

/hold cancel

PR is reviewable

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2025
@Tal-or
Copy link
Collaborator Author

Tal-or commented Mar 19, 2025

/cc @ffromani @shajmakh

@openshift-ci openshift-ci bot requested a review from shajmakh March 19, 2025 14:11
Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provisional LGTM, some questions inside

To support running  MG on hosted clusters, we should check whether we're
running on standart OpenShift or HyperShift
and collect the relevant data accordingly.

Signed-off-by: Talor Itzhak <[email protected]>
@Tal-or
Copy link
Collaborator Author

Tal-or commented Mar 20, 2025

/hold

I would like to add some additional tests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
Tal-or added 3 commits March 20, 2025 14:51
Find the nodes associated with nrop via the poolName
when running on hypershift.

The rest of the flow should be similar.

Signed-off-by: Talor Itzhak <[email protected]>
@Tal-or
Copy link
Collaborator Author

Tal-or commented Mar 20, 2025

/hold cancel

The tests are more robust now.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1eb667c into openshift-kni:main Mar 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants