-
Notifications
You must be signed in to change notification settings - Fork 17
CNF-15623:must-gather: add support for hypershift #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-15623:must-gather: add support for hypershift #1234
Conversation
Signed-off-by: Talor Itzhak <[email protected]>
Signed-off-by: Talor Itzhak <[email protected]>
/hold |
@Tal-or: This pull request references CNF-15623 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold cancel PR is reviewable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provisional LGTM, some questions inside
To support running MG on hosted clusters, we should check whether we're running on standart OpenShift or HyperShift and collect the relevant data accordingly. Signed-off-by: Talor Itzhak <[email protected]>
/hold I would like to add some additional tests |
Find the nodes associated with nrop via the poolName when running on hypershift. The rest of the flow should be similar. Signed-off-by: Talor Itzhak <[email protected]>
see: https://docs.docker.com/reference/dockerfile/#entrypoint Signed-off-by: Talor Itzhak <[email protected]>
Signed-off-by: Talor Itzhak <[email protected]>
/hold cancel The tests are more robust now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To support running MG on hosted clusters, we should check whether we're
running on standard OpenShift or HyperShift
and collect the relevant data accordingly.
Signed-off-by: Talor Itzhak [email protected]