e2e: classifying tests using labels #1170
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The label package contains a list of labels that can be used in the e2e and serial tests to indicate and point certain behavior or characteristics of the various tests. Those can be filtered/focused by ginkgo before the test runs. Example: `ginkgo --label-filter="!slow"` means avoid any specs labelled `slow` The types defined in the package are type aliases and not new defined types. This is done in order to avoid casting every time the labels are being used. This package allow greater readability, prevent typos (what can easily happen while using plain-text) and a common place to hold and documents every label that is being used in the tests. Signed-off-by: Talor Itzhak <[email protected]>
replace all plain-text labels with the aliases from the label package. There are more labels to be added, but this is a good start. Signed-off-by: Talor Itzhak <[email protected]>
| @@ -0,0 +1,72 @@ | |||
| package label | |||
There was a problem hiding this comment.
missing copyright boilerplate (hack/boilerplate.go.txt)
| // Tier0 are automated unit tests | ||
| // Minimal time needed to execute (minutes to 1 hour) | ||
| // Process criteria: | ||
| // 100% automated, must-pass 100% | ||
| // Development maintains tests, and reviews result |
There was a problem hiding this comment.
descriptions are nice but they don't reflect what our serial tests are and wants to be
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
The label package contains a list of labels that can be used in
the e2e and serial tests to indicate and point certain behavior or characteristics
of the various tests.
Those can be filtered/focused by ginkgo before the test runs.
Example:
ginkgo --label-filter="!slow"means avoid any specs labelledslowThe types defined in the package are type aliases and not new defined
types. This is done in order to avoid casting every time the labels are
being used.
This package allow greater readability, prevent typos (what can easily
happen while using plain-text) and
a common place to hold and documents every label that is being
used in the tests.
Signed-off-by: Talor Itzhak [email protected]