[release-4.18] selinux: per-nodegroup SCC toggle #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consume upstream fixes Signed-off-by: Francesco Romani <[email protected]>
incorporate the SCC v2 as provided by deployer <= 0.21.3 Signed-off-by: Francesco Romani <[email protected]>
there are cases on which object (aka cluster) level annotations are not good enough, so add limited per-nodegroup annotation. This is another strong hint we should have had an object per nodegroup rather than a single object for all nodegroups. Signed-off-by: Francesco Romani <[email protected]>
rename internal helpers for consistency. no intended changes in behavior. Signed-off-by: Francesco Romani <[email protected]>
Now that we have per-nodegroup annotation, we can enable back the custom selinux policy per-nodegroup (vs per-cluster), allowing granular upgrades. Signed-off-by: Francesco Romani <[email protected]>
we prefer and we intend to have per-nodegroup configuration, so drop per-object global annotation check and honor the custom-selinux policy per-nodegroup, enabling more granularity. This is meant to enable blue-green or anyhow partial upgrades. Signed-off-by: Francesco Romani <[email protected]>
Ince a nodegroup has the legacy custom selinux policy annotation, it should keep using it, so it should keep reconciling the MachineConfig and ensure its present. Once the annotation is removed, the MachineConfig should be deleted. Add a testcase to ensure this behavior. Signed-off-by: Francesco Romani <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ffromani
added
cherry-pick-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1124
/assign ffromani