Skip to content
This repository was archived by the owner on Mar 23, 2020. It is now read-only.

Remove bootstrap VM and some other assets #88

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Remove bootstrap VM and some other assets #88

merged 1 commit into from
Sep 10, 2019

Conversation

e-minguez
Copy link
Contributor

Fixes #52 #71

@e-minguez
Copy link
Contributor Author

I'm not sure if:

  • Removing the virtual networks is useful
  • Removing the ocp/ folder is useful
  • Removing the 172.22.0.2 from the ~/.ssh/known_hosts is useful

Comments?

@sreichar
Copy link
Collaborator

sreichar commented Sep 6, 2019

I am of the opinion that removing hte virtual network is not useful
Think the other two make sense

Did you look to see what @hardys recommended - using openshift_baremetal_intaller destroy cluster?

@e-minguez
Copy link
Contributor Author

IIRC @hardys mentioned here is there is no complete support right now for destroy cluster.

I've just executed it and:

$ ocp/openshift-baremetal-install destroy cluster --log-level debug --dir ocp/
DEBUG OpenShift Installer v4.2.0                   
DEBUG Built from commit 8c9abe40f7616303c03cafdc9ad612cd8fa7bd6b 
DEBUG Deleting bare metal resources                
DEBUG FIXME: delete resources!                     
DEBUG Purging asset "Terraform Variables" from disk 
DEBUG Purging asset "Kubeconfig Admin Client" from disk 
DEBUG Purging asset "Kubeadmin Password" from disk 
DEBUG Purging asset "Certificate (journal-gatewayd)" from disk 
DEBUG Purging asset "Metadata" from disk           
DEBUG Purging asset "Cluster" from disk     

Copy link
Collaborator

@sreichar sreichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sreichar
Copy link
Collaborator

sreichar commented Sep 9, 2019

@e-minguez Just would like to confirm you tested

@e-minguez
Copy link
Contributor Author

Can confirm I tested it. The Masters are not cleaned but that's because the destroy cluster command doesn't do it. I think this is the most clean stuff we can make right now.

@sreichar sreichar merged commit 23ac33c into openshift-kni:master Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running make clean makes your host unreachable
2 participants