-
Notifications
You must be signed in to change notification settings - Fork 53
Add test cases for dynamic_templates mappings #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for dynamic_templates mappings #446
Conversation
} | ||
|
||
@Test | ||
@DisabledIf(value = "isOSCTest", disabledReason = "https://github.com/opensearch-project/opensearch-java/issues/1513") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this to see the test failing
Note that one of the test cases currently fails and requires opensearch-java#1513 to be resolved first, thus it has been disabled for the OSC client. Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Ralph Ursprung <[email protected]>
7b58d7a
to
a4520c7
Compare
Signed-off-by: Andriy Redko <[email protected]>
@rursprung this is expected behavior, the values with dots are not accepted to |
the whole goal here is to have this split up - i.e. indexing |
OK, so it is really very tricky, I think the case I run into is: // First doc
// Second doc
So this does not work obviously. To your point, the general exception that dots are expanded into properties for |
this should be: "names" : {
"a" : {
"b" : "c"
}
}
}
exactly, that's the problem and why i've reported it to but i'm not familiar at all with the code generation going on there, so i don't know how to get this fixed there (i guess either the source from which it is being generated is wrong or the generator has a bug?) |
@rursprung closing this one, #443 has a reproducer now, thank you |
Description
alternative version of #443 from @reta which shows the failing test. feel free to take that commit over into the original PR and close this PR here instead.
Note that one of the test cases currently fails and requires opensearch-project/opensearch-java#1513 to be resolved first, thus it has been disabled for the OSC client.
Issues Resolved
n/a
Check List
All tests pass(the whole point is to show a failing test; though it's disabled, so technically it passes CI)New functionality has been documented.New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.