Skip to content

adding fields mapping parameter docs #9554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 24, 2025
Merged

adding fields mapping parameter docs #9554

merged 9 commits into from
Apr 24, 2025

Conversation

AntonEliatra
Copy link
Contributor

Description

adding fields mapping parameter docs

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator

@mgodwan Could you please review this PR? Thanks!

@AntonEliatra
fixing typo
1761e32 
Signed-off-by: Anton Rubin <[email protected]>
@AntonEliatra
Merge branch 'adding-fields-mapping-parameter-docs' of github.com:Ant…
b9a1e04 
…onEliatra/documentation-website into adding-fields-mapping-parameter-docs
@mgodwan
Copy link
Member

mgodwan commented Apr 3, 2025

@kolchfa-aws I'll be able to check the PR by tomorrow.

mgodwan
mgodwan approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@mgodwan mgodwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for different examples to highlight how this is useful as well.

kolchfa-aws
kolchfa-aws reviewed Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonEliatra! Please see my comments and let me know if you have any questions.

@kolchfa-aws kolchfa-aws added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Apr 24, 2025
AntonEliatra and others added 2 commits April 24, 2025 15:17
@AntonEliatra @kolchfa-aws
Apply suggestions from code review
7819d51 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
Update fields.md
8b3e8a4 
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
Copy link
Contributor Author

@kolchfa-aws Thats updated now

@kolchfa-aws kolchfa-aws added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Apr 24, 2025
@kolchfa-aws kolchfa-aws assigned natebower and unassigned kolchfa-aws Apr 24, 2025
natebower
natebower reviewed Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra Two minor editorial changes. Thanks!

@AntonEliatra @natebower
Apply suggestions from code review
7903907 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
Copy link
Contributor Author

@natebower I accepted those changes

natebower
natebower approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AntonEliatra! LGTM

@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Apr 24, 2025
@natebower natebower merged commit 6ebd7fd into opensearch-project:main Apr 24, 2025
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 24, 2025
@github-actions @kolchfa-aws @natebower
adding fields mapping parameter docs (#9554)
affb525 
* adding fields mapping parameter docs

Signed-off-by: Anton Rubin <[email protected]>

* fixing typo

Signed-off-by: Anton Rubin <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Update fields.md

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 6ebd7fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 24, 2025
Merged
@AntonEliatra AntonEliatra deleted the adding-fields-mapping-parameter-docs branch April 24, 2025 18:59
github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@opensearch-trigger-bot
adding fields mapping parameter docs (#9554) (#9734)
a31b9cb
@ProHoster
Copy link

@kolchfa-aws Could you please review this PR? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws left review comments

@mgodwan mgodwan mgodwan approved these changes

@natebower natebower natebower approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@natebower natebower

Labels
backport 2.19 Content gap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AntonEliatra @kolchfa-aws @mgodwan @ProHoster @natebower