-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ML Commons Neural Embeddings Tutorial update #9536
Conversation
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
ff673f4
to
209facb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @chloewqg!
@chloewqg Should we also list this change in https://opensearch.org/docs/latest/breaking-changes/? Also, are any other pages in the https://opensearch.org/docs/latest/vector-search/ai-search/index/ section affected by this? |
Signed-off-by: Chloe Gao <[email protected]>
209facb
to
bf748c1
Compare
Sure. I updated the breaking change document. Please take a look. For your second question, I took a look at the current five tutorials, none of them are using nested value like this and thus we don't need to update them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @chloewqg! Does my suggestion convey the desired meaning?
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Chloe Gao <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Chloe Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws @chloewqg One minor addition. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-9536-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9c407303435e7d68bcd218c65d3e961f7a3603bb
# Push it to GitHub
git push --set-upstream origin backport/backport-9536-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.19 Then, create a pull request where the |
Description
Update the Ingest Pipeline Setup for TextEmbeddingProcessor for desired behavior.
Issues Resolved
Closes opensearch-project/neural-search#1243
Version
2.19 and above
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.