-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding token graph docs #9499
base: main
Are you sure you want to change the base?
adding token graph docs #9499
Conversation
Signed-off-by: Anton Rubin <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Anton Rubin <[email protected]>
@kolchfa-aws that's ready for review now |
@udabhas Could you please review this PR? |
Signed-off-by: kolchfa-aws <[email protected]>
_analyzers/token-graph.md
Outdated
|
||
```json | ||
curl -X POST "https://localhost:9200/synonym_index/_doc/1" -u admin:admin -k -H 'Content-Type: application/json' -d ' | ||
{ "content": "ssd is critical" }' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the operation to PUT as we are passing the docid.
update to not use curl .
PUT /synonym_index/_doc/1
{ "content": "ssd is critical" }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes are required for the examples. Please take a look at them once.
Signed-off-by: Anton Rubin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @AntonEliatra! Please see my comments and let me know if you have any questions.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
Description
Adding token graph documentation
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.