-
Notifications
You must be signed in to change notification settings - Fork 110
Change Docker image version in Java upgrades #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timtebeek
wants to merge
5
commits into
main
Choose a base branch
from
change-docker-image-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
db406af
Change Docker image version in Java upgrades
timtebeek 99b30ad
Extract UpgradeDockerImageVersion to separate recipe
timtebeek 2636f2f
Apply suggestions from code review
timtebeek b2e66e9
Change Docker image version in Java upgrades
timtebeek 280b8e3
Apply suggestions from code review
timtebeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
src/main/java/org/openrewrite/java/migrate/UpgradeDockerImageVersion.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Copyright 2024 the original author or authors. | ||
| * <p> | ||
| * Licensed under the Moderne Source Available License (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p> | ||
| * https://docs.moderne.io/licensing/moderne-source-available-license | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.openrewrite.java.migrate; | ||
|
|
||
| import lombok.EqualsAndHashCode; | ||
| import lombok.Value; | ||
| import org.openrewrite.Option; | ||
| import org.openrewrite.Recipe; | ||
| import org.openrewrite.docker.ChangeFrom; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| @EqualsAndHashCode(callSuper = false) | ||
| @Value | ||
| public class UpgradeDockerImageVersion extends Recipe { | ||
|
|
||
| @Option(displayName = "Java version", | ||
| description = "The Java version to upgrade to.", | ||
| example = "11") | ||
| Integer version; | ||
|
|
||
| String displayName = "Upgrade Docker image Java version"; | ||
| String description = "Upgrade Docker image tags to use the specified Java version. " + | ||
| "Updates common Java Docker images including eclipse-temurin, amazoncorretto, azul/zulu-openjdk, " + | ||
| "and others. Also migrates deprecated images (openjdk, adoptopenjdk) to eclipse-temurin."; | ||
|
|
||
| @Override | ||
| public List<Recipe> getRecipeList() { | ||
| List<Recipe> recipes = new ArrayList<>(); | ||
| if (version == null) { // for uninitialized version | ||
| return recipes; | ||
| } | ||
| // Deprecated images -> migrate to eclipse-temurin | ||
| String[] deprecatedImages = {"openjdk", "adoptopenjdk"}; | ||
| String[] currentImages = { | ||
| "eclipse-temurin", "amazoncorretto", "azul/zulu-openjdk", | ||
| "bellsoft/liberica-openjdk-debian", "bellsoft/liberica-openjdk-alpine", | ||
| "bellsoft/liberica-openjdk-centos", "ibm-semeru-runtimes", "sapmachine" | ||
| }; | ||
| // Common tag suffixes to preserve when upgrading current images | ||
| // Longer suffixes must come before shorter ones to match correctly | ||
| String[] commonSuffixes = { | ||
| "-jdk-alpine", "-jre-alpine", | ||
| "-jdk-noble", "-jre-noble", | ||
| "-jdk-jammy", "-jre-jammy", | ||
| "-jdk-focal", "-jre-focal", | ||
| "-jdk-centos7", "-jre-centos7", | ||
| "-jdk-ubi9-minimal", "-jre-ubi9-minimal", | ||
| "-jdk-nanoserver", "-jre-nanoserver", | ||
| "-jdk-windowsservercore", "-jre-windowsservercore", | ||
| "-alpine", | ||
| "-jdk", "-jre" | ||
| }; | ||
| for (int oldVersion = 8; oldVersion < version; oldVersion++) { | ||
| // Deprecated images: match specific suffixes first to preserve them | ||
| for (String image : deprecatedImages) { | ||
| for (String suffix : commonSuffixes) { | ||
| recipes.add(new ChangeFrom(image, oldVersion + suffix, null, null, "eclipse-temurin", version + suffix, null, null)); | ||
| } | ||
| } | ||
| // Deprecated images: fall back to wildcard for remaining patterns | ||
| for (String image : deprecatedImages) { | ||
| recipes.add(new ChangeFrom(image, oldVersion + "*", null, null, "eclipse-temurin", version.toString(), null, null)); | ||
| } | ||
| // Current images: match specific suffixes first to preserve them | ||
| for (String image : currentImages) { | ||
| for (String suffix : commonSuffixes) { | ||
| recipes.add(new ChangeFrom(image, oldVersion + suffix, null, null, null, version + suffix, null, null)); | ||
| } | ||
| } | ||
| // Current images: fall back to wildcard for remaining patterns | ||
| for (String image : currentImages) { | ||
| recipes.add(new ChangeFrom(image, oldVersion + "*", null, null, null, version.toString(), null, null)); | ||
| } | ||
| } | ||
| return recipes; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're missing quite a few common ones here.