Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Apache HttpClient Dependency #9

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

bsmahi
Copy link
Contributor

@bsmahi bsmahi commented Mar 25, 2024

What's changed?

Upgraded Apache HttpClient Dependency to 5.2.x

What's your motivation?

With this migration, we can able to migrate org.apache.httpcomponents.core5:httpcore5 automatically without manual intervention.

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek linked an issue Mar 25, 2024 that may be closed by this pull request
@timtebeek timtebeek requested a review from knutwannheden March 25, 2024 13:17
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/apache/commons/io/UseJavaStandardCharsetsTest.java
    • lines 19-18
    • lines 33-32

@sambsnyd sambsnyd merged commit 86f78af into openrewrite:main Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Upgrade Apache Http Client from 5.1+ to 5.2+
2 participants