Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[55] Use recursive: true on ChangePackage for coll3->4 recipe #56

Merged

Conversation

crankydillo
Copy link
Contributor

@crankydillo crankydillo commented Jan 30, 2025

What's your motivation?

Ran into this while using the recipe on some code:)

Anything in particular you'd like reviewers to focus on?

Biggest thing is I'm worried this can't be 'blanket' done. I asked on the original PR. I've not used Apache commons collection a lot in my career.

Anyone you would like to review specifically?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • [x ] I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Positive test added. I read the guide once upon a time:)

@timtebeek timtebeek merged commit f810765 into openrewrite:main Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

UpgradeApacheCommonsCollections_3_4 does not recursively change the package
2 participants