-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MigrateRequestConfig #45
Conversation
@timtebeek Do you have any better idea for line 103 and 144. I suppose this isn't a good way to insert a new variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/apache/httpclient5/UsernamePasswordCredentials.java
- lines 28-29
src/main/java/org/openrewrite/apache/httpclient5/MigrateRequestConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim te Beek <[email protected]>
src/main/java/org/openrewrite/apache/httpclient5/MigrateRequestConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/apache/httpclient5/MigrateRequestConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/apache/httpclient5/MigrateRequestConfig.java
Outdated
Show resolved
Hide resolved
That was a neat puzzle there @SiBorea ! To fix most of the type validation issues I've flipped around the order as compared to what you had before; now we first create a new |
What's changed?
I created a
MigrateRequestConfig
recipe forRequestConfig
, it maybe complicated to finish.Currently only
RequestConfig.Builder.setStaleConnectionCheckEnabled(false)
is migrated.Checklist