Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change commons-collections3 ListUtils.EMPTY_LIST -> to Java's Collections.emptyList() #23

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Change commons-collections3 ListUtils.EMPTY_LIST -> to Java's Collections.emptyList() #23

merged 1 commit into from
Aug 6, 2024

Conversation

crankydillo
Copy link
Contributor

@crankydillo crankydillo commented Aug 6, 2024 •
edited by timtebeek
Loading

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek changed the title [22] coll3's ListUtils.EMPTY_LIST -> to java's Collections.emptyList Change commons-collections3 ListUtils.EMPTY_LIST -> to Java's Collections.emptyList() Aug 6, 2024
@timtebeek timtebeek self-requested a review August 6, 2024 16:00
@timtebeek timtebeek added enhancement New feature or request recipe labels Aug 6, 2024
timtebeek
timtebeek approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see! Thanks for the immediate fix!

@timtebeek timtebeek merged commit db959db into openrewrite:main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@crankydillo crankydillo

Labels
enhancement New feature or request recipe
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

commons-collections 3->4 Upgrade should replace ListUtils.EMPTY_LIST with Collections.emptyList
2 participants
@crankydillo @timtebeek