Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Apache HttpClient 5.x ClassicRequestBuilder #19

Merged
merged 2 commits into from
Jun 10, 2024
Merged

use Apache HttpClient 5.x ClassicRequestBuilder #19

merged 2 commits into from
Jun 10, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Jun 8, 2024 •
edited
Loading

What's changed?

support Apache HttpClient 5.x ClassicRequestBuilder

https://hc.apache.org/httpcomponents-core-5.3.x/current/httpcore5/apidocs/org/apache/hc/core5/http/io/support/ClassicRequestBuilder.html

What's your motivation?

improve support for Apache HttpClient version 5.x

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@sullis
Copy link
Contributor Author

sullis commented Jun 8, 2024

CI build failure 🤔

image

@timtebeek timtebeek self-requested a review June 8, 2024 20:45
@timtebeek
Copy link
Contributor

As discussed on Slack the CI failure should have been resolved through

@sullis sullis force-pushed the sean/ClassicRequestBuilder branch from c8338bc to 7880997 Compare June 10, 2024 11:05
@sullis sullis changed the title use Apache HttpClient ClassicRequestBuilder use Apache HttpClient 5.x ClassicRequestBuilder Jun 10, 2024
@sullis sullis marked this pull request as ready for review June 10, 2024 11:25
@sullis
Copy link
Contributor Author

sullis commented Jun 10, 2024

This PR is ready for review. cc: @timtebeek

timtebeek
timtebeek approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Glad to see this omission covered, and the openrewrite/rewrite AddImport bug it uncovered resolved as well.

@timtebeek timtebeek merged commit 78d8e8a into openrewrite:main Jun 10, 2024
2 checks passed
@sullis sullis deleted the sean/ClassicRequestBuilder branch June 10, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@sullis sullis

Labels
recipe
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sullis @timtebeek