Handle change in constructor signature for HttpHost.
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Thanks so much for pointing these out and contributing back to the project; really helpful to know and see this fixed!
Should make into the next version, expected in a week or two. Until then it's available from our snapshot versions.
Glad to hear we got you most of the way there already; let us know if there's anything else you'd like to see covered here, or on any of the other modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Handle change in constructor signature for
HttpHost.See docs here:
(old version)
https://hc.apache.org/httpcomponents-core-4.4.x/current/httpcore/apidocs/org/apache/http/HttpHost.html
(new version)
https://hc.apache.org/httpcomponents-core-5.2.x/current/httpcore5/apidocs/org/apache/hc/core5/http/HttpHost.html
See
What's your motivation?
We have handled this for our internal migration, so I just want to add this upstream so that others can use this.
Thank you for this automatic migration! 👍