Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for Apache Commons Math 3.x #13

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Mar 28, 2024

What's changed?

add recipe for Apache Commons Math 3.x

What's your motivation?

to remove old Apache Commons libraries :)

Anything in particular you'd like reviewers to focus on?

n/a

Anyone you would like to review specifically?

n/a

Have you considered any alternatives or workarounds?

n/a

Any additional context

n/a

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/apache/commons/io/UseJavaStandardCharsetsTest.java
    • lines 19-18
    • lines 33-32

@sullis
Copy link
Contributor Author

sullis commented Mar 28, 2024

cc: @timtebeek

@sambsnyd sambsnyd merged commit c456ec2 into openrewrite:main Mar 28, 2024
2 checks passed
@sullis sullis deleted the add-recipe-commons-math-3x branch March 28, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants