feature: turn on FFI API for stream module #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dndx Will you have a look at this? We're going to remove the non-FFI APIs in both the stream and http lua modules anyway. |
|
@james-callahan Have you ran stream_lua's tests with this change? |
No. I was never able to get the test suite to run on my computer. |
|
@james-callahan Then it may break stuff. See how travis ci runs the test suite, for example: https://github.com/openresty/stream-lua-nginx-module/blob/master/.travis.yml Or you can just use travis ci to test your own branch. |
|
Done as part of #71 which took care of removing the retired CFunction API altogether in favor of the FFI implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally part of openresty/stream-lua-nginx-module#122
This PR removes the limitations that force us to use
NGX_LUA_NO_FFI_APIin the stream module.