Skip to content

feature: enhance ssl.get_shared_ssl_ciphers() for stream #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chensunny
Copy link
Contributor

Summy

This pull request introduces a new feature to retrieve shared SSL ciphers in the ngx_stream_lua_module and includes corresponding tests. The main changes involve adding a new FFI function, updating the Lua API, and implementing a new test case to validate the feature.

Related PR

Closed #505
openresty/lua-nginx-module#1962
openresty/lua-nginx-module#2424
openresty/stream-lua-nginx-module#378

New Feature: Shared SSL Ciphers Retrieval

  • FFI Function Addition:

    • Added a new FFI function ngx_stream_lua_ffi_req_shared_ssl_ciphers in lib/ngx/ssl.lua to retrieve shared SSL ciphers. This function includes an option to filter GREASE values.
  • Lua API Update:

    • Exposed the new FFI function as ngx_lua_ffi_req_shared_ssl_ciphers in the Lua API for the ngx_stream_lua_module.

Testing Enhancements

  • Test Plan Update:

    • Increased the planned test count in t/stream/ssl.t to accommodate the new test case.
  • New Test Case:

    • Added a comprehensive test case (TEST 29) in t/stream/ssl.t to validate the retrieval of shared SSL ciphers. This test ensures the function works correctly by logging the shared cipher IDs and verifying the output in the error log.

@chensunny chensunny changed the title feature : enhance ssl.get_shared_ssl_ciphers() for stream feature: enhance ssl.get_shared_ssl_ciphers() for stream Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant