Skip to content

add lua_ssl_certificate for server to certificate client #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rainingmaster
Copy link
Member

@rainingmaster rainingmaster commented May 5, 2017

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.
I have add lua_ssl_certificate ported from proxy_module, and try to solve problem like here. When use ngx.tcp.socket, we can send our certificate to server to pass verification. we have use like this in our private module, is it suitable?
If it is suitable, I will add more test cases~

@agentzh
Copy link
Member

agentzh commented May 5, 2017

@rainingmaster Maybe we should make it explicit that we are supporting client certificates here? The current names are a bit confusing.

I think maybe it's better to set this in the Lua API instead since this global setting affects all the SSL cosockets, which may give surprises. Like in this PR: #997

@rainingmaster
Copy link
Member Author

OH, I kwnow. Yes, that is more flexible in that way.

@CodingMinds
Copy link

@rainingmaster Is there a new PR ?

@agentzh
Copy link
Member

agentzh commented Jun 8, 2017

@CodingMinds Yes. See #997.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants