-
Notifications
You must be signed in to change notification settings - Fork 1
Port multiple PRs from source repositories #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
a50ff91
Add SKILL.md for porting PRs and AGENTS.md for coding guidelines
conico974 1d3b7e5
update skill
conico974 dc05a5a
Port https://github.com/opennextjs/opennextjs-aws/pull/1118 as a test
conico974 8614793
Port https://github.com/opennextjs/opennextjs-aws/pull/1117
conico974 a559cfe
update skill
conico974 132ad05
Port https://github.com/opennextjs/opennextjs-aws/pull/1114
conico974 fe987a1
Port PR https://github.com/opennextjs/opennextjs-aws/pull/1107
conico974 6f3d001
update skills
conico974 643b158
Port PR https://github.com/opennextjs/opennextjs-aws/pull/1108
conico974 e9d9243
Port PR https://github.com/opennextjs/opennextjs-aws/pull/1104
conico974 3abe5d2
Port PR https://github.com/opennextjs/opennextjs-aws/pull/1101
conico974 b4463be
Port PR https://github.com/opennextjs/opennextjs-aws/pull/1098
conico974 a0783a4
chore: port PR #1083 from source repository
conico974 3d5945c
chore: port PR #1105 from source repository
conico974 c8337b0
chore: port PR #1097 from source repository
conico974 e082616
chore: port PR #1122 from source repository
conico974 78d6ad7
chore: update port PR skill instructions for staging and committing c…
conico974 322d80c
chore: port PR #1126 from source repository
conico974 ab06c09
linting
conico974 79c5af3
chore: port PR #1127 from source repository
conico974 7204997
chore: port PR #1138 from source repository
conico974 e14b0b9
chore: port PR #1133 from source repository
conico974 3bfab5a
chore: port PR #1142 from source repository
conico974 a35e4f9
chore: port PR #1147 from source repository
conico974 2a65d4a
chore: port PR #1150 from source repository
conico974 a1d153e
fix lockfile
conico974 5170ff5
Merge remote-tracking branch 'origin/main' into conico/port-cloudflare
conico974 3ba5da2
fix test
conico974 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1083 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1083 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1097 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1097 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1105 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "@opennextjs/aws": patch | ||
| --- | ||
|
|
||
| Ported PR #1122 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1122 | ||
|
|
||
| Changed `checkRunningInsideNextjsApp` function signature to accept `{ appPath: string }` instead of full `BuildOptions` object, making it more flexible for use in the migrate command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1122 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1122 | ||
|
|
||
| Applied bugfixes and improvements to the `migrate` command: | ||
|
|
||
| - Fixed extra newlines when appending to files (updated `conditionalAppendFileSync` function signature to use options object with `appendIf` and `appendPrefix`) | ||
| - Fixed error when `public` directory is missing (now creates parent directories automatically) | ||
| - Fixed Next.js config file update to check if the file exists before attempting to update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1126 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1127 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1127 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1133 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1138 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1142 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1146 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1147 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@opennextjs/cloudflare": patch | ||
| --- | ||
|
|
||
| Ported PR #1150 from source repository | ||
|
|
||
| https://github.com/opennextjs/opennextjs-cloudflare/pull/1150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 74 additions & 1 deletion
75
packages/cloudflare/src/api/overrides/asset-resolver/index.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personally i wouldn't include the
2>&1 | tail -20in the snippet - most will reach for that out-of-the-box depending on what they're doing, so inlining might make them do it in cases where they might have gone for a different approach.This runs formatting, linting, and TypeScript checks. Only the tail of the output is shown to see the result.
7. Run Unit Tests
After code checks pass, run only the unit tests from the tests-unit package:
pnpm --filter tests-unit testThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good call, I used a bunch of different AI to test them on that and some were very dumb 😄