Skip to content

- #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clevervi wants to merge 1 commit into from
Closed

- #1255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Server/Components/CustomModels/models.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,16 @@ class WebServer
return httplib::Server::HandlerResponse::Handled;
}
}
else if (req.sockaddr.ss_family == AF_INET6)
else
{
// TODO: Add IPV6 support.
// The allowlist only holds the IPv4 addresses of connected players
// (see allowIPAddress), so a request from any other address family
// (IPv6 included) can never be on it. Until IPv6 allowlisting is
// implemented we deny those requests instead of letting them through
// unchecked, otherwise the player-IP restriction is trivially bypassed
// by downloading the models over IPv6.
res.status = 401;
return httplib::Server::HandlerResponse::Handled;
}

return httplib::Server::HandlerResponse::Unhandled;
Expand Down