Map-9: Develop #691
Draft
Map-9: Develop #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Märki <[email protected]>
Signed-off-by: Nicolas Märki <[email protected]>
Signed-off-by: Nicolas Märki <[email protected]>
Signed-off-by: Nicolas Märki <[email protected]>
Signed-off-by: Nicolas Märki <[email protected]>
Feature/animated dashes
Signed-off-by: Nicolas Märki <[email protected]>
Signed-off-by: Nicolas Märki <[email protected]>
Fix mixup after fd35aea. Signed-off-by: Nicolas Märki <[email protected]>
Signed-off-by: Nicolas Märki <[email protected]>
Small fixes, e.g. avoid crashing on missing font results. Use small JNI function to load textures, instead of depending on a full-blown GL framework for Java. Somewhat simplistic and not optimized, but probably good enough. DataLoader uses java http client which is a bit bare-bones. Might have to be made more tweakable.
Name suffix is linux_amd64 (plus _debug for debug build).
Ready manager thread starvation
Tile Clear Update and fix ReadyManager Starvation
TileWrapper keeps a gpc_polygon which is not freed on destruction of the TileWrapper. In some cases this was explicitly freed, but not everywhere. To simplify this, wrap the gpc_polygon in a semi-safe holder to ensure its always destroyed. Unfortunately the gpc_... API does not use const pointers for the input arguments, so the wrapper cannot be made properly safe. Also, add missing intitialization for Tiled2dMapSource::curT/curZoom, reported by valgrind.
…ction-fixes Bugfix/icon layer 3d selection fixes
…olygon Fix memory leak from gpc_polygon in TileWrapper
Add abstract BaseDataLoader to share the common logic for DataLoaders in Java and use this in the HttpDataLoader. Remove the LocalDataLoader as it's never been used and seems redundant with the LocalDataProvider-option on the Tiled2dMapVectorLayerBuilder. With the BaseDataLoader, loading from resources can be easily added in project-specific subclasses. Extend the "quirks" (draw the frame repeatedly) to make the OffscreenMapRenderer work reliably again after rebasing these java bindings.
Initialize texture with premultiplied alpha, as expected by shader.
…w triggering manually
…reen-quirks Java bindings: add BaseDataLoader, fixes and quirks for OffscreenMapRenderer
maerki
requested review from
stmitt,
matzf,
maurhofer-ubique and
zimmermannubique
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.