Restrict camera to bounds when zooming with tap and move

[maurhofer-ubique]

Summary by CodeRabbit

• Bug Fixes
  • Improved map navigation by ensuring the camera center stays within the corrected bounds after zoom adjustments.

[coderabbitai]

Walkthrough

The update introduces a refinement in the 2D map camera handling by incorporating a step to ensure the camera's center remains within predefined bounds, post-zoom adjustments. This enhancement is achieved through the invocation of a new function, clampCenterToPaddingCorrectedBounds, effectively maintaining the camera's view within desired parameters.

Changes

Files	Change Summary
.../src/map/camera/MapCamera2d.cpp	Introduced clampCenterToPaddingCorrectedBounds in onMove to keep camera center within corrected bounds after zooming.

🐇✨
In the realm of code, where the map does unfold,
A rabbit hopped in, with a fix so bold.
"Keep the view in bounds," it said with a cheer,
Ensuring the camera, now perfectly clear.
🌍🔍✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 5ef6af7 and 6aa4251.

Files selected for processing (1)

• shared/src/map/camera/MapCamera2d.cpp (1 hunks)

Additional comments: 1

shared/src/map/camera/MapCamera2d.cpp (1)

• 497-497: The addition of clampCenterToPaddingCorrectedBounds in the onMove method after zoom adjustments ensures the camera's center is clamped within the bounds corrected for padding. This change aligns with the PR objectives to enhance user experience by maintaining the camera's view within the desired map area during zoom operations.