Don't replace vector layer tile updates

[maurhofer-ubique]

(colliding with multiple sources)

Summary by CodeRabbit

• Refactor
  • Improved the tile update notification mechanism in map vector sources.

[coderabbitai]

Walkthrough

The recent modifications involve the removal of the MailboxDuplicationStrategy::replaceNewest argument from the listener.message call within the notifyTilesUpdates methods of both the Tiled2dMapVectorSource and Tiled2dVectorGeoJsonSource classes. This change simplifies the message sending strategy by eliminating the specification to always replace the newest message, potentially affecting how tile updates are communicated to listeners.

Changes

File Path	Change Summary
.../vector/Tiled2dMapVectorSource.cpp & .../geojson/Tiled2dVectorGeoJsonSource.h	Removed MailboxDuplicationStrategy::replaceNewest argument from listener.message call in notifyTilesUpdates method.

🐇✨
In the realm of code, where the vectors play,
A rabbit hopped through, simplifying the day.
"No more 'replaceNewest', let's keep it clear,"
It whispered, as the codebase felt cheer.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e8866be and 4eb4472.

Files selected for processing (2)

• shared/src/map/layers/tiled/vector/Tiled2dMapVectorSource.cpp (1 hunks)
• shared/src/map/layers/tiled/vector/geojson/Tiled2dVectorGeoJsonSource.h (1 hunks)

Additional comments: 4

shared/src/map/layers/tiled/vector/geojson/Tiled2dVectorGeoJsonSource.h (2)

• 60-60: The change to remove the MailboxDuplicationStrategy::replaceNewest argument from the listener.message call in the notifyTilesUpdates method aligns with the PR's objective to prevent tile data replacement from multiple sources. This should help in managing tile updates more effectively without overwriting newer updates.
• 57-63: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-93]

The Tiled2dVectorGeoJsonSource class implementation appears to be well-structured and follows good OOP practices. The use of inheritance from Tiled2dMapVectorSource and GeoJSONTileDelegate is appropriate for the functionality it provides. The constructor initialization list is correctly used to initialize base class and member variables. Methods like getCurrentTiles, notifyTilesUpdates, didLoad, isReadyToRenderOffscreen, cancelLoad, loadDataAsync, hasExpensivePostLoadingTask, and postLoadingTask are well-defined, serving their intended purposes without apparent issues. The class maintains a clear separation of concerns, with each method focused on a specific aspect of the source's behavior.

shared/src/map/layers/tiled/vector/Tiled2dMapVectorSource.cpp (2)

• 90-90: The modification in the notifyTilesUpdates method, specifically the removal of the MailboxDuplicationStrategy::replaceNewest argument from the listener.message call, is consistent with the PR's goal to enhance the handling of tile updates from multiple sources. This change should contribute to avoiding data collision and ensuring that updates are managed more reliably.
• 87-93: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-103]

The implementation of the Tiled2dMapVectorSource class in this file is comprehensive and adheres to good coding practices. The constructor properly initializes the base class and member variables. The loadDataAsync, cancelLoad, hasExpensivePostLoadingTask, postLoadingTask, notifyTilesUpdates, and getCurrentTiles methods are implemented with clear responsibilities and efficient use of resources. The error handling within postLoadingTask using try-catch blocks for specific exceptions is a good practice, ensuring that the application can gracefully handle errors during tile data processing. Overall, the class structure and method implementations are well-designed, promoting maintainability and scalability.