fix interaction

[maerki]

Summary by CodeRabbit

• Refactor
  • Improved the touch interaction handling in map controls for enhanced user experience with multi-touch gestures.

[coderabbitai]

Walkthrough

The recent update introduces a std::recursive_mutex named stateMutex as a class member in the DefaultTouchHandler class, enhancing thread safety during touch event handling. This change aims to protect shared resources from concurrent access, ensuring the application's stability and reliability without altering the existing touch event handling logic.

Changes

File Path	Change Summary
.../src/map/controls/DefaultTouchHandler.h	Added a std::recursive_mutex named stateMutex.

🐰✨
In the realm of touch and trace,
A lock now guards the shared space.
With every tap and swipe, we grace,
Ensuring safety's steady pace.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f8596f3 and d155be7.

Files selected for processing (2)

• shared/src/map/controls/DefaultTouchHandler.cpp (10 hunks)
• shared/src/map/controls/DefaultTouchHandler.h (1 hunks)

Additional comments: 11

shared/src/map/controls/DefaultTouchHandler.h (1)

• 66-66: The addition of std::recursive_mutex stateMutex; introduces thread safety to the class. Ensure that all public methods that modify shared state are properly locking this mutex to prevent race conditions.

shared/src/map/controls/DefaultTouchHandler.cpp (10)

• 63-64: Proper use of std::lock_guard<std::recursive_mutex> to lock stateMutex in onTouchEvent method ensures thread safety when accessing or modifying shared state.
• 157-158: Locking stateMutex in handleTouchDown method is correct and ensures thread safety for state changes.
• 186-187: The use of stateMutex in handleMove method is appropriate for protecting shared state modifications.
• 221-222: Locking stateMutex in handleTouchUp method is correctly implemented for thread-safe state updates.
• 304-305: The handleTouchCancel method correctly locks stateMutex to ensure thread safety during state reset.
• 318-319: handleTwoFingerDown method properly locks stateMutex to protect shared state during two-finger touch handling.
• 348-349: In handleTwoFingerMove, locking stateMutex is correctly done to ensure thread safety for state transitions.
• 377-378: The handleTwoFingerUp method uses stateMutex correctly for thread-safe state management.
• 395-396: Locking stateMutex in handleMoreThanTwoFingers method ensures thread safety for resetting the state.
• 419-420: Correct use of stateMutex in checkState method for thread-safe state checks and transitions.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d155be7 and 826a3e1.

Files selected for processing (1)

• shared/src/map/controls/DefaultTouchHandler.cpp (10 hunks)

Files skipped from review as they are similar to previous changes (1)

• shared/src/map/controls/DefaultTouchHandler.cpp