Fixes icon offset

[bastianmorath]

Summary by CodeRabbit

• Bug Fixes
  • Corrected icon offset retrieval in map symbols to ensure accurate positioning.

[coderabbitai]

Walkthrough

A bug fix has been implemented in the SymbolVectorStyle class affecting the getIconOffset method. Previously, this method erroneously returned the X component for both X and Y offsets. The update corrects this, ensuring that the Y component is now accurately returned, thereby fixing the icon positioning based on the context.

Changes

File Path	Change Summary
.../public/SymbolVectorLayerDescription.h	Corrected getIconOffset to return proper Y component.

Poem

🐇💻 In the land of code and vector,
A rabbit found a bug to pester.
Tweaked the Y, aligned it right,
Icons now offset just right. 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 88d6458 and 4595b98.

Files selected for processing (1)

• shared/public/SymbolVectorLayerDescription.h (1 hunks)

Additional comments: 2

shared/public/SymbolVectorLayerDescription.h (2)

• 305-305: The change to the getIconOffset method now correctly returns the Y component of the offset, addressing the bug where the X component was returned twice. This fix is critical for ensuring that icons are positioned correctly on the map.
• 305-305: Verify that the corrected getIconOffset method in SymbolVectorStyle does not introduce any side effects in the SymbolVectorLayerDescription class, especially in the clone method where the style object is used.