Allow opening statepoint files when one is already open#177
Open
pshriwise wants to merge 1 commit intoopenmc-dev:developfrom
Open
Allow opening statepoint files when one is already open#177pshriwise wants to merge 1 commit intoopenmc-dev:developfrom
pshriwise wants to merge 1 commit intoopenmc-dev:developfrom
Conversation
Collaborator
Author
|
The test code is fully codex-generated. It's a lot of line changes and while I'd like to have more testing here it's not the type of testing I'm primarily concerned with. Happy to remove it if we think that's best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another QOL upgrade here. It's been bothering me for a while that you can't more cleanly open a new statepoint file with one already open. Feels clunky for it to fail and force the user to close the existing file manually. This takes care of that by providing a notice if one is open and optionally opening the file open dialog anyway after confirmation.