Conversation
The batch variance is formed as sum_sq/n - mean**2, a difference of accumulated sums. When every realization scores nearly the same value the true variance is zero and rounding can leave the difference just below it, so the square root produces NaN and a RuntimeWarning. Because get_pandas_dataframe() ends with df.dropna(axis=1), a single NaN silently removes the whole "std. dev." column from the dataframe. Clamp the variance at zero, as mean_stdev() in src/output.cpp already does and as keff_std is guarded in src/eigenvalue.cpp. Handle a single realization separately, where n - 1 is a division by zero. The standard deviation stays NaN for bins that scored, as it was, but the user now gets a statement of the problem rather than numpy's "invalid value encountered in divide"; bins that never scored stay at zero and stay silent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MGFo4cAtRRZGxr3sWnqNPc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch variance is formed as sum_sq/n - mean**2, a difference of accumulated sums. When every realization scores nearly the same value the true variance is zero and rounding can leave the difference just below it, so the square root produces NaN and a RuntimeWarning. Because get_pandas_dataframe() ends with df.dropna(axis=1), a single NaN silently removes the whole "std. dev." column from the dataframe.
Clamp the variance at zero, as mean_stdev() in src/output.cpp already does and as keff_std is guarded in src/eigenvalue.cpp.
Handle a single realization separately, where n - 1 is a division by zero. The standard deviation stays NaN for bins that scored, as it was, but the user now gets a statement of the problem rather than numpy's "invalid value encountered in divide"; bins that never scored stay at zero and stay silent.
Fixes #2408
Checklist
I have run clang-format (version 18) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)