Conversation
Aggregating each filter bin into a contiguous datatype reduces the count passed to MPI_Bcast by a factor of the score and estimator dimensions, but the count is still an int. A tally with more filter bins than an int can represent therefore still fails, which is the part of openmc-dev#914 that remained open after the aggregation was introduced. Broadcast in chunks no larger than INT_MAX filter bins, mirroring the approach already used for reductions in mpi::reduce_buffer. All ranks derive the loop bounds from the same tally layout, so the sequence of collective calls stays identical across ranks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ci4aodNXq5BPbv3PXZNcp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aggregating each filter bin into a contiguous datatype reduces the count passed to MPI_Bcast by a factor of the score and estimator dimensions, but the count is still an int. A tally with more filter bins than an int can represent therefore still fails, which is the part of #914 that remained open after the aggregation was introduced.
Broadcast in chunks no larger than INT_MAX filter bins, mirroring the approach already used for reductions in mpi::reduce_buffer. All ranks derive the loop bounds from the same tally layout, so the sequence of collective calls stays identical.
Fixes #914
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)