Skip to content

Set billboard opacity #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2015
Merged

Conversation

gberaudo
Copy link
Member

Handle opacity property in the converter.

@gberaudo gberaudo force-pushed the set_billboard_opacity branch from 5f91b74 to d5d3687 Compare December 17, 2014 10:35
@gberaudo
Copy link
Member Author

This PR allows modifying the opacity of an ol3 image Point dynamically.
It is made possible following the recent ol3 PR merge openlayers/openlayers#3044.

@ahocevar
Copy link
Member

ahocevar commented Jan 2, 2015

Looks good. Please merge.

gberaudo added a commit that referenced this pull request Jan 20, 2015
@gberaudo gberaudo merged commit d3d4a20 into openlayers:master Jan 20, 2015
@schmidtk
Copy link
Contributor

This works if the opacity is set at the style level, but it may be set at the layer level. Are there plans to handle that case?

@gberaudo
Copy link
Member Author

Unfortunately, this OL3 mechanism does not have equivalent in Cesium.
A good solution would avoid destroying and recreating all primitives.
It would require Ol3 to propagate layer changes in a finer way.

@ahocevar
Copy link
Member

I'll take a look. Maybe there is a way.

@ahocevar
Copy link
Member

@schmidtk As far as I can tell, this change also works for an opacity set on the layer level. The style that is queried for the opacity still comes from olcs.core.computePlainStyle, which takes both feature and layer styles into account and executes the style function for each feature. Can you confirm?

@ahocevar
Copy link
Member

I see now what you mean @schmidtk: an opacity set by ol.layer.Base#setOpacity. I'll see if I can come up with something.

@ahocevar
Copy link
Member

@schmidtk I came up with #166 for layer opacity support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants