support batch id label for canary strategy #251
Conversation
PersistentJZH
force-pushed
the
zhihao/feat/support-batch-id-label-for-canary-and-bluegreen-strategy
branch
from
0980b79 to
227898c
Compare
Signed-off-by: zhihao jian <[email protected]> fix
PersistentJZH
force-pushed
the
zhihao/feat/support-batch-id-label-for-canary-and-bluegreen-strategy
branch
from
227898c to
e8e810c
Compare
| @@ -182,6 +182,15 @@ func (rc *realController) CalculateBatchContext(release *v1beta1.BatchRelease) ( | |||
| NoNeedUpdatedReplicas: noNeedUpdate, | |||
| PlannedUpdatedReplicas: plannedUpdate, | |||
| DesiredUpdatedReplicas: desiredUpdate, | |||
| FilterFunc: func(pods []*corev1.Pod, ctx *batchcontext.BatchContext) []*corev1.Pod { | |||
There was a problem hiding this comment.
per previous code design, FilterFunc is used to filtering pods durning rollback situation (refer to the impl func FilterPodsForUnorderedUpdate and FilterPodsForOrderedUpdate), the comparison of IsConsistentWithRevision is common and not necessary to include it in the FilterFunc. In addition, in the case of canary deployment, the logic to select pods of canary deployment can also be included in the FilterFunc.
There was a problem hiding this comment.
In the partitionstyle scenario, compare the pod label with UpdateRevision to filter pod. In the canarystyle scenario, need to compare it with StableRevision. Can I refer to the implementation of #250 so that different patcher can have different revisionConsistents Func.
Ⅰ. Describe what this PR does
new pods created by each step of a rollout canary release will be patched with the rollouts.kruise.io/rollout-id and rollouts.kruise.io/rollout-batch-id labels, which is useful for platforms to select pods with some specific batch
Ⅱ. Does this pull request fix one issue?
fixes #249
Ⅲ. Special notes for reviews