Skip to content

8362181: [lworld] Include verification for strict fields in ClassFile API #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: lworld
Choose a base branch
from

Conversation

liach
Copy link
Member

@liach liach commented Jul 9, 2025

The lack of classfile verifier recognition of strict fields is the only part of class file API support left for strict fields.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8362181: [lworld] Include verification for strict fields in ClassFile API (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1506/head:pull/1506
$ git checkout pull/1506

Update a local copy of the PR:
$ git checkout pull/1506
$ git pull https://git.openjdk.org/valhalla.git pull/1506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1506

View PR using the GUI difftool:
$ git pr show -t 1506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1506.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362181: [lworld] Include verification for strict fields in ClassFile API

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • 7e4c1bc: 8361082: [lworld] RewriteBytecodesInlineTest fails with SIGSEGV
  • 680efc4: 8361250: [lworld] use more IRNode regexes in valhalla IR tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@liach liach marked this pull request as ready for review July 14, 2025 15:08
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2025
@liach liach changed the title Include verification for strict fields in ClassFile API 8362181: [lworld] Include verification for strict fields in ClassFile API Jul 14, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2025

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants