-
Notifications
You must be signed in to change notification settings - Fork 122
8362181: [lworld] Include verification for strict fields in ClassFile API #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sensible
@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@liach The pull request is being re-evaluated and the inactivity timeout has been reset. |
@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@liach The pull request is being re-evaluated and the inactivity timeout has been reset. |
327013e
to
63e0257
Compare
@liach Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Only 2 unrelated failures in tier 1-3. Integrating. /integrate |
Going to push as commit 2c2f4b2.
Your commit was automatically rebased without conflicts. |
The lack of classfile verifier recognition of strict fields is the only part of class file API support left for strict fields.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1506/head:pull/1506
$ git checkout pull/1506
Update a local copy of the PR:
$ git checkout pull/1506
$ git pull https://git.openjdk.org/valhalla.git pull/1506/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1506
View PR using the GUI difftool:
$ git pr show -t 1506
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1506.diff
Using Webrev
Link to Webrev Comment