Skip to content

Conversation

liach
Copy link
Member

@liach liach commented Jul 9, 2025

The lack of classfile verifier recognition of strict fields is the only part of class file API support left for strict fields.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8362181: [lworld] Include verification for strict fields in ClassFile API (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1506/head:pull/1506
$ git checkout pull/1506

Update a local copy of the PR:
$ git checkout pull/1506
$ git pull https://git.openjdk.org/valhalla.git pull/1506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1506

View PR using the GUI difftool:
$ git pr show -t 1506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1506.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362181: [lworld] Include verification for strict fields in ClassFile API

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@liach liach marked this pull request as ready for review July 14, 2025 15:08
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2025
@liach liach changed the title Include verification for strict fields in ClassFile API 8362181: [lworld] Include verification for strict fields in ClassFile API Jul 14, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2025

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2025

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@liach
Copy link
Member Author

liach commented Aug 11, 2025

/touch

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@liach The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2025

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@liach
Copy link
Member Author

liach commented Sep 9, 2025

/touch

@openjdk
Copy link

openjdk bot commented Sep 9, 2025

@liach The pull request is being re-evaluated and the inactivity timeout has been reset.

@liach liach force-pushed the feature/cf-verify-strict branch from 327013e to 63e0257 Compare September 22, 2025 13:46
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@liach Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@liach
Copy link
Member Author

liach commented Sep 22, 2025

Only 2 unrelated failures in tier 1-3. Integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

Going to push as commit 2c2f4b2.
Since your change was applied there have been 81 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2025
@openjdk openjdk bot closed this Sep 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2025
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@liach Pushed as commit 2c2f4b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants