Skip to content

8365305: The ARIA role ‘contentinfo’ is not valid for the element <footer> #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psoujany wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8365305: The ARIA role ‘contentinfo’ is not valid for the element <footer> #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/jdk.javadoc/share/classes/jdk/javadoc/internal/html/HtmlTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,8 +586,7 @@ public static HtmlTree EM(String body) {
* @return the element
*/
public static HtmlTree FOOTER() {
return new HtmlTree(HtmlTag.FOOTER)
.setRole(HtmlAttr.Role.CONTENTINFO);
return new HtmlTree(HtmlTag.FOOTER);
}

/**
Expand Down
6 changes: 3 additions & 3 deletions test/langtools/jdk/javadoc/doclet/testHtmlLandmarkRegions/TestHtmlLandmarkRegions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void testModules(Path base) throws Exception {
<div class="header">
<h1 class="title">Document Title</h1>""",
"""
<footer role="contentinfo"> """,
<footer> """,
"""
bottom text"""
);
Expand Down Expand Up @@ -113,7 +113,7 @@ public void testPackages(Path base) throws Exception {
<div class="header">
<h1 class="title">Document Title</h1>""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");
}
Expand Down Expand Up @@ -150,7 +150,7 @@ public void testDocFiles(Path base) throws Exception {
"""
<main role="main">A sample doc file""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text"""
);
Expand Down
34 changes: 17 additions & 17 deletions test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ void html5Output() {
<nav role="navigation">
<!-- ========= START OF TOP NAVBAR ======= -->""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand All @@ -109,7 +109,7 @@ void html5Output() {
<section class="package-description" id="package-description">
<div class="block">Test package.</div>""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");
// No package description
Expand Down Expand Up @@ -150,7 +150,7 @@ void html5Output() {
<section class="hierarchy">
<h2 title="Enum Class Hierarchy">Enum Class Hierarchy</h2>""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""" );

Expand All @@ -171,7 +171,7 @@ void html5Output() {
<main role="main">
<div class="header">""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand Down Expand Up @@ -199,7 +199,7 @@ void html5Output() {
<h2 title="pkg.*">pkg.*</h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand All @@ -220,7 +220,7 @@ void html5Output() {
<main role="main">
<div class="header">""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand All @@ -243,7 +243,7 @@ void html5Output() {
<h2 title="Package">Package&nbsp;<a href="pkg/package-summary.html">pkg</a></h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand Down Expand Up @@ -279,7 +279,7 @@ void html5Output() {
<h2 title="Enum Class Hierarchy">Enum Class Hierarchy</h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand All @@ -299,7 +299,7 @@ void html5Output() {
<div class="main-grid">
<main role="main">""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand Down Expand Up @@ -337,7 +337,7 @@ void html5Output() {
<h3>Class or Interface</h3>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand Down Expand Up @@ -387,7 +387,7 @@ void html5Output() {
<h2>Method Details</h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand Down Expand Up @@ -428,7 +428,7 @@ void html5Output() {
<h2>Method Details</h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand Down Expand Up @@ -460,7 +460,7 @@ void html5Output() {
<h2>Method Details</h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand All @@ -487,7 +487,7 @@ void html5Output() {
<h2>Constructor Details</h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand All @@ -514,7 +514,7 @@ void html5Output() {
<h2>Constructor Details</h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand Down Expand Up @@ -552,7 +552,7 @@ void html5Output() {
<h2>Element Details</h2>
""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");

Expand Down Expand Up @@ -581,7 +581,7 @@ void html5Output() {
/span></div>
<div class="summary-table three-column-summary">""",
"""
<footer role="contentinfo">""",
<footer>""",
"""
bottom text""");
}
Expand Down