-
Notifications
You must be signed in to change notification settings - Fork 133
8326705: Test CertMsgCheck.java fails to find alert certificate_required #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
19ac618
to
f25abf6
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
83846ab
to
6d33f98
Compare
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8326705
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
Thanks for the repeated review! |
/integrate |
Going to push as commit 03ab6e4.
Your commit was automatically rebased without conflicts. |
Follow up to JDK-8311644.
Resolved problemlist, test was not listed.
Test passes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2070/head:pull/2070
$ git checkout pull/2070
Update a local copy of the PR:
$ git checkout pull/2070
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2070/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2070
View PR using the GUI difftool:
$ git pr show -t 2070
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2070.diff
Using Webrev
Link to Webrev Comment