Skip to content

8326705: Test CertMsgCheck.java fails to find alert certificate_required #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 11, 2025

Follow up to JDK-8311644.

Resolved problemlist, test was not listed.
Test passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326705 needs maintainer approval

Issue

  • JDK-8326705: Test CertMsgCheck.java fails to find alert certificate_required (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2070/head:pull/2070
$ git checkout pull/2070

Update a local copy of the PR:
$ git checkout pull/2070
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2070/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2070

View PR using the GUI difftool:
$ git pr show -t 2070

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2070.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/2069 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326705: Test CertMsgCheck.java fails to find alert certificate_required

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 16e6e2a: 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION
  • caec079: 8334457: Test javax/swing/JTabbedPane/bug4666224.java fail on macOS with because pressing the ‘C’ key does not switch the layout to WRAP_TAB_LAYOUT
  • 58059ee: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 4ffc5e60776353b03e9a557c39148e378b1690e2 8326705: Test CertMsgCheck.java fails to find alert certificate_required Aug 11, 2025
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 11, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2025

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8326705 branch from 19ac618 to f25abf6 Compare August 11, 2025 08:21
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

⚠️ @GoeLin This backport pull request is too large to be automatically evaluated as clean.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Aug 12, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/2069 to master August 13, 2025 07:48
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8326705
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 13, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 13, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 13, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 13, 2025

Thanks for the repeated review!

@GoeLin
Copy link
Member Author

GoeLin commented Aug 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

Going to push as commit 03ab6e4.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 16e6e2a: 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION
  • caec079: 8334457: Test javax/swing/JTabbedPane/bug4666224.java fail on macOS with because pressing the ‘C’ key does not switch the layout to WRAP_TAB_LAYOUT
  • 58059ee: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 13, 2025
@openjdk openjdk bot closed this Aug 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 13, 2025
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@GoeLin Pushed as commit 03ab6e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8326705 branch August 13, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants