Skip to content

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 20, 2025

Hi all,

This pull request contains a backport of commit fdb74ed4 from the openjdk/jdk repository.

The commit being backported was authored by Phil Race on 13 Oct 2022 and was reviewed by David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8295301 needs maintainer approval

Issue

  • JDK-8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3975/head:pull/3975
$ git checkout pull/3975

Update a local copy of the PR:
$ git checkout pull/3975
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3975/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3975

View PR using the GUI difftool:
$ git pr show -t 3975

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3975.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d1f2faf: 8342782: AWTEventMulticaster throws StackOverflowError using AquaButtonUI
  • e4bea56: 8365913: Support latest MSC_VER in abstract_vm_version.cpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fdb74ed45240477bd08eb40ede5eaa2345ca6b5d 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04 Sep 20, 2025
@openjdk
Copy link

openjdk bot commented Sep 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 20, 2025
@mrserb mrserb marked this pull request as ready for review September 21, 2025 04:18
@openjdk
Copy link

openjdk bot commented Sep 21, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2025
@mrserb
Copy link
Member Author

mrserb commented Sep 21, 2025

/approval request
Clean backport. A few tests were added to the problem list. All of them fail on JDK 17, same as on 21.

@openjdk
Copy link

openjdk bot commented Sep 21, 2025

@mrserb
8295301: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 21, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 21, 2025
@mrserb
Copy link
Member Author

mrserb commented Sep 21, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Sep 21, 2025

Going to push as commit 1eb4722.
Since your change was applied there have been 2 commits pushed to the master branch:

  • d1f2faf: 8342782: AWTEventMulticaster throws StackOverflowError using AquaButtonUI
  • e4bea56: 8365913: Support latest MSC_VER in abstract_vm_version.cpp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 21, 2025
@openjdk openjdk bot closed this Sep 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2025
@openjdk
Copy link

openjdk bot commented Sep 21, 2025

@mrserb Pushed as commit 1eb4722.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant