Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 19, 2025

I backport this for parity with 17.0.18-oracle


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358048 needs maintainer approval

Issue

  • JDK-8358048: java/net/httpclient/HttpsTunnelAuthTest.java incorrectly calls Thread::stop (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3964/head:pull/3964
$ git checkout pull/3964

Update a local copy of the PR:
$ git checkout pull/3964
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3964/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3964

View PR using the GUI difftool:
$ git pr show -t 3964

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3964.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d288ca28be7bfba3abe9f54cefbe53e73c25707e 8358048: java/net/httpclient/HttpsTunnelAuthTest.java incorrectly calls Thread::stop Sep 19, 2025
@openjdk
Copy link

openjdk bot commented Sep 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 19, 2025
@openjdk
Copy link

openjdk bot commented Sep 19, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant