Skip to content

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Sep 19, 2025

This pull request contains a backport of commit d5908231 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Richard Reingruber on 22 Jul 2025 and was reviewed by Paul Hohensee.

The backport required trivial adaptations

  • of copyright headers
  • of the hunk that includes os.inline.hpp because of a diff in the context
  • and because frame::abi_minframe was renamed frame::common_abi in higher releases

Risk is low because the patch is small and ppc only. The code is only reached when profiling with jfr or async-profiler.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8350106 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8350106: [PPC] Avoid ticks_unknown_not_Java AsyncGetCallTrace() if JavaFrameAnchor::_last_Java_pc not set (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3957/head:pull/3957
$ git checkout pull/3957

Update a local copy of the PR:
$ git checkout pull/3957
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3957

View PR using the GUI difftool:
$ git pr show -t 3957

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3957.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2025

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d5908231ebc16f443b3fc9b2ebf03cc4deb67373 8350106: [PPC] Avoid ticks_unknown_not_Java AsyncGetCallTrace() if JavaFrameAnchor::_last_Java_pc not set Sep 19, 2025
@openjdk
Copy link

openjdk bot commented Sep 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base
Development

Successfully merging this pull request may close these issues.

1 participant