Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 20, 2025

I backport this for parity with 17.0.17-oracle.

Removed some OpenJDK 21 functionality.
Test using this pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8355370 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355370: Include server name in HTTP test server thread names to improve diagnostics (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3861/head:pull/3861
$ git checkout pull/3861

Update a local copy of the PR:
$ git checkout pull/3861
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3861

View PR using the GUI difftool:
$ git pr show -t 3861

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3861.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/3857 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355370: Include server name in HTTP test server thread names to improve diagnostics

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 7d9a43839ad190a53efdbcc7afd1728760c14e21 8355370: Include server name in HTTP test server thread names to improve diagnostics Aug 20, 2025
@openjdk
Copy link

openjdk bot commented Aug 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Aug 20, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2025

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8355370 branch from a768de5 to 3e096b4 Compare August 22, 2025 07:04
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Aug 22, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3857 to master August 22, 2025 07:06
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8355370
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Aug 22, 2025
Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 27, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Sep 1, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

Going to push as commit c3f9905.
Since your change was applied there have been 8 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2025
@openjdk openjdk bot closed this Sep 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2025
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@GoeLin Pushed as commit c3f9905.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8355370 branch September 1, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants