8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

[GoeLin]

I backport this for parity with 17.0.17-oracle based on the push to 21.

Resolved Coipyright in src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java

I had to adapt the test as it again depends on AutoClosable of HttpClient.
Here it seems ok to just not shut down the Client as it is done in other tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8335181 needs maintainer approval

Issue

• JDK-8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient (Bug - P3 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)
• Alexey Bakhtin (@alexeybakhtin - Reviewer) Review applies to 32bf9327

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3783/head:pull/3783
$ git checkout pull/3783

Update a local copy of the PR:
$ git checkout pull/3783
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3783/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3783

View PR using the GUI difftool:
$ git pr show -t 3783

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3783.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

Reviewed-by: rschmelter, abakhtin
Backport-of: 209939a90e9b804da4c37ebd978b088cb8f41ead

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 01d92b5: 8343618: Stack smashing in awt_InputMethod.c on Linux s390x
• 6a2ed7c: 8355249: Remove the use of WMIC from the entire source code
• c90978b: 8341964: Add mechanism to disable different parts of TLS cipher suite
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/d2dad32242dfd6e76ea5c487345d73848776cd22...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full - Incremental (42da2aee)
• 02: Full - Incremental (32bf9327)
• 01: Full - Incremental (3932288c)
• 00: Full (ae0f03bc)

[GoeLin]

GHA failure: build failed, unrelated:
E: Couldn't download packages: libc6-dev

[schmelter-sap]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[alexeybakhtin]

Hello, thank you for the backport.
Shouldn't we update the copyright year in src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java as described in the overview and the JDK 21 backport?
The rest looks good to me.

[GoeLin]

Hi @alexeybakhtin , thanks for the catch, fixed!

[GoeLin]

Our nighttests showed

STARTED H2GoAwayTest::testUnprocessedRaisesException 'testUnprocessedRaisesException()'
java.lang.SecurityException: access denied ("java.net.URLPermission" "https://127.0.0.1:55295/test" "HEAD:")
at java.net.http/jdk.internal.net.http.HttpClientImpl.send(HttpClientImpl.java:892)
at java.net.http/jdk.internal.net.http.HttpClientFacade.send(HttpClientFacade.java:133)
at H2GoAwayTest.testUnprocessedRaisesException(H2GoAwayTest.java:173)

Locally, the test passes. I assume this is a inference with other tests, as we can not shutdown the HttpClient in 17. Other, similar tests all run in othervm mode. Adding othervm mode fixes the issue in our nightly tests.

[schmelter-sap]

Looks good.

[GoeLin]

Again thanks for the reviews!

[GoeLin]

/integrate

[openjdk]

Going to push as commit 4b2d777.
Since your change was applied there have been 5 commits pushed to the master branch:

• 01d92b5: 8343618: Stack smashing in awt_InputMethod.c on Linux s390x
• 6a2ed7c: 8355249: Remove the use of WMIC from the entire source code
• c90978b: 8341964: Add mechanism to disable different parts of TLS cipher suite
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/d2dad32242dfd6e76ea5c487345d73848776cd22...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 4b2d777.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.