8355249: Remove the use of WMIC from the entire source code

[kurashige23]

Hi all,

This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code

JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported.

Original patch does not apply cleanly because JDK-8340311 is not backported to jdk17. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java.
In addition, JDK-8344275 doesn't apply to 17, and NosuchElementException is only used in 17, so I made a slightly different fix for those as well.

I confirmed that Win8301247Test.java passes on Windows Server 2022.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8355249 needs maintainer approval

Issue

• JDK-8355249: Remove the use of WMIC from the entire source code (Enhancement - P4 - Approved)

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Author)
• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3688/head:pull/3688
$ git checkout pull/3688

Update a local copy of the PR:
$ git checkout pull/3688
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3688

View PR using the GUI difftool:
$ git pr show -t 3688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3688.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kurashige23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355249: Remove the use of WMIC from the entire source code

Reviewed-by: asemenyuk, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• c90978b: 8341964: Add mechanism to disable different parts of TLS cipher suite
• f78f1bf: 8319174: Enhance robustness of some j.m.BigInteger constructors
• 90b5b24: 8351601: [JMH] test UnixSocketChannelReadWrite failed for 2 threads config

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (de79559b)
• 00: Full (4122a9c0)

[kurashige23]

@phohensee

Thank you for your review about jdk21 and jdk11.
Could you also review this PR?.

[alexeysemenyukoracle]

jpackage changes look good

[kurashige23]

@phohensee

Thank you for your review about jdk21 and jdk11.
Could you also review this PR?.

Sorry for sudden mention. I would appreciate it if you could confirm it.

[phohensee]

Done.

[openjdk]

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kurashige23]

@GoeLin

Sorry for sudden mention. Could you add maintainer approval for JDK-8355249 please?

Oh, I forgot to issue approval request. I'm sorry, I issued it below.
I would appreciate it if you could check it. Thank you.

[kurashige23]

/approval request Backporting this protects against the risk of future removal of WMIC.
Original patch does not apply cleanly because JDK-8340311 and JDK-8344275 are not backported to jdk17, and NosuchElementException is only used in 17, so I Fixed a part of the original patch.
This fix constists of makefile fix and test fix, low risk.
I confirmed that Win8301247Test.java passes on Windows Server 2022.

[openjdk]

@kurashige23
8355249: The approval request has been created successfully.

[RealCLanger]

Please enable Github Actions and let them run for a basic verification. Thanks.

[kurashige23]

@RealCLanger

My apologies for forgetting to enable GHA.
I've enabled and run it.
There are 2 errors in linux-cross-compile. These errors are related to download issues and are not related to this PR.

Thanks.

[kurashige23]

Thank you for your review.

/integrate

[openjdk]

@kurashige23
Your change (at version de79559) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 6a2ed7c.
Since your change was applied there have been 3 commits pushed to the master branch:

• c90978b: 8341964: Add mechanism to disable different parts of TLS cipher suite
• f78f1bf: 8319174: Enhance robustness of some j.m.BigInteger constructors
• 90b5b24: 8351601: [JMH] test UnixSocketChannelReadWrite failed for 2 threads config

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @kurashige23 Pushed as commit 6a2ed7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.