Skip to content

8301793: AlgorithmId should not encode a missing parameters field as NULL unless hardcoded #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

varada1110
Copy link

@varada1110 varada1110 commented Jun 2, 2025

Hi all,

This pull request contains a backport of commit a97271e3 from the openjdk/jdk repository.

The commit being backported was authored by Weijun Wang on 6 Mar 2023 and was reviewed by Sean Mullan.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301793 needs maintainer approval

Issue

  • JDK-8301793: AlgorithmId should not encode a missing parameters field as NULL unless hardcoded (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3615/head:pull/3615
$ git checkout pull/3615

Update a local copy of the PR:
$ git checkout pull/3615
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3615

View PR using the GUI difftool:
$ git pr show -t 3615

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3615.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2025

👋 Welcome back varadam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a97271e3b5d5a08fc503a11cd3e253974fb77ce6 8301793: AlgorithmId should not encode a missing parameters field as NULL unless hardcoded Jun 2, 2025
@openjdk
Copy link

openjdk bot commented Jun 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 2, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2025

Webrevs

@varada1110
Copy link
Author

/approval 8301793 request the backport fix where the AlgorithmId should omit the parameters field when it is not required, rather than encoding it as NULL, unless the algorithm explicitly mandates. JTREG testing successful for sun/security

@openjdk
Copy link

openjdk bot commented Jun 2, 2025

@varada1110
8301793: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 2, 2025
@GoeLin
Copy link
Member

GoeLin commented Jun 5, 2025

Hi Varada,
please first get a review, then label for approval.
Please edit the description of the PR and tell why this is not clean.
I'm not sure this is a good backport. Please tell in the approval comment in JBS why you
want to backport this and give a risk assessment.

@openjdk openjdk bot removed the approval label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants