Skip to content

8346285: Update jarsigner compatibility test for change in default digest algorithm #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented May 28, 2025

Backport for Oracle 17.0.16 parity. Clean backport, test only, modified test passes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346285 needs maintainer approval

Issue

  • JDK-8346285: Update jarsigner compatibility test for change in default digest algorithm (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3613/head:pull/3613
$ git checkout pull/3613

Update a local copy of the PR:
$ git checkout pull/3613
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3613/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3613

View PR using the GUI difftool:
$ git pr show -t 3613

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3613.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2025

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2025

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346285: Update jarsigner compatibility test for change in default digest algorithm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3a46af4: 8358660: Bump update version for OpenJDK: jdk-17.0.17

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e7d21fcf4949106e89afd413e9abc47d622dd47a 8346285: Update jarsigner compatibility test for change in default digest algorithm May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

⚠️ @phohensee This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 28, 2025
@mlbridge
Copy link

mlbridge bot commented May 28, 2025

Webrevs

@phohensee
Copy link
Member Author

/approval request Backport for Oracle 17.0.16 parity. Clean backport, test only, modified test passes.

@openjdk
Copy link

openjdk bot commented May 28, 2025

@phohensee
8346285: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label May 28, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 5, 2025
@phohensee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

Going to push as commit c1c2475.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 3a46af4: 8358660: Bump update version for OpenJDK: jdk-17.0.17

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2025
@openjdk openjdk bot closed this Jun 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@phohensee Pushed as commit c1c2475.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant