Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Oct 27, 2025

On our way to more stable GHA.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8341861 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8341861: GHA: Use only retention mechanism to remove bundles (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3108/head:pull/3108
$ git checkout pull/3108

Update a local copy of the PR:
$ git checkout pull/3108
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3108

View PR using the GUI difftool:
$ git pr show -t 3108

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3108.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 29ae26517f9c1fd5e641b3a560aa93e370920506 8341861: GHA: Use only retention mechanism to remove bundles Oct 27, 2025
@openjdk
Copy link

openjdk bot commented Oct 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

@shipilev
Copy link
Member Author

/approval request Same reason as for other update releases.

@shipilev
Copy link
Member Author

Oh, this is not a clean backport because of the contextual differences? Need a quick review as well, please and thank you!

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@shipilev
8341861: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant