8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build

[kurashige23]

Hi all,

This is a backport of JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build

I couldn't reproduce the bug reported in JDK-8352942 in 11u but it will potentially happen as described in openjdk/jdk#24646 (comment) . So I think this fix should be backported to 11u.

Original patch applies cleanly to 11u.

Testing: TestMemoryOptions.java executed by 32/64bit module passes and Winsows Server 2019

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8352942 needs maintainer approval

Issue

• JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build (Bug - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3054/head:pull/3054
$ git checkout pull/3054

Update a local copy of the PR:
$ git checkout pull/3054
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3054/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3054

View PR using the GUI difftool:
$ git pr show -t 3054

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3054.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build

Reviewed-by: shade, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 1468cfa: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures
• 646b6b5: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA
• 0927ca7: 8358538: Update GHA Windows runner to 2025
• ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/501f90c4902e41ff8fd5fdbfb8fd694771496f5b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (fe2dc315)

[shipilev]

Looks fine.

[openjdk]

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[phohensee]

Looks clean.

[kurashige23]

/clean

[openjdk]

@kurashige23 The /clean pull request command is not enabled for this repository

[kurashige23]

Thank you for review.

/approval request No risk, only a test change.
Clean backport.
TestMemoryOptions.java executed by 32/64bit module passes on Winsows Server 2019.

[openjdk]

@kurashige23
8352942: The approval request has been created successfully.

[kurashige23]

@jerboaa

Sorry for sudden mention, could you add maintainer approval for this PR? Thanks.

[jerboaa]

Seems fine, yes.

/approve yes

[openjdk]

@jerboaa
8352942: The approval request has been approved.

[kurashige23]

Thank you everyone for reviews.

/integrate

[openjdk]

@kurashige23
Your change (at version fe2dc31) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 7ff53b5.
Since your change was applied there have been 4 commits pushed to the master branch:

• 1468cfa: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures
• 646b6b5: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA
• 0927ca7: 8358538: Update GHA Windows runner to 2025
• ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/501f90c4902e41ff8fd5fdbfb8fd694771496f5b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @kurashige23 Pushed as commit 7ff53b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.