8212155: Race condition when posting dynamic_code_generated event leads to JVM crash

[krk]

Backport of JDK-8212155.

The patch did not apply cleanly due to a merge conflict. The original code JvmtiThreadState::state_for(JavaThread::current()) had already been refactored to JavaThread::current()->jvmti_thread_state() in this branch.

I have also removed the @requires vm.jvmti tag from the test, as it is not supported by the jtreg version in JDK 11.

The DynamicCodeGeneratedTest was confirmed to fail without this patch and passes with it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8212155 needs maintainer approval

Issue

• JDK-8212155: Race condition when posting dynamic_code_generated event leads to JVM crash (Bug - P3 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3051/head:pull/3051
$ git checkout pull/3051

Update a local copy of the PR:
$ git checkout pull/3051
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3051

View PR using the GUI difftool:
$ git pr show -t 3051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3051.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@krk This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8212155: Race condition when posting dynamic_code_generated event leads to JVM crash

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 7ff53b5: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build
• 1468cfa: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures
• 646b6b5: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA
• ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/501f90c4902e41ff8fd5fdbfb8fd694771496f5b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (9f252d80)

[krk]

Tagging reviewer of the original commit: @sspitsyn

[shipilev]

Makes sense. Please make sure to run the remaining jvmti tests:

jdk11u-dev/test/hotspot/jtreg/TEST.groups

Lines 462 to 464 in cec1ef0

	# JVMTI tests
	vmTestbase_nsk_jvmti = \
	vmTestbase/nsk/jvmti

jdk11u-dev/test/hotspot/jtreg/TEST.groups

Lines 59 to 60 in cec1ef0

	hotspot_serviceability = \
	serviceability

[openjdk]

⚠️ @krk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[krk]

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg:vmTestbase_nsk_jvmti       640   640     0     0
   jtreg:test/hotspot/jtreg:hotspot_serviceability     178   178     0     0

[krk]

/approval request Fixes a critical JVM crash from a race condition when posting dynamic_code_generated JVMTI events.

The patch required manual conflict resolution in JvmtiExport.cpp because JvmtiThreadState::state_for() was previously refactored in this branch. The new regression test, DynamicCodeGeneratedTest, required the removal of an unsupported jtreg tag and was verified to fail without the patch and pass with it.

This fix has been stable in mainline since June 2021. The risk is low, as the fix is a minimal, defensive check.

[openjdk]

@krk
8212155: The approval request has been created successfully.

[shipilev]

@gnu-andrew, @jerboaa -- want to take a look at this one? Looks fairly safe to me, and avoids production JVM crashes with profilers :)

[jerboaa]

Approved. Please follow up with a backport of https://bugs.openjdk.org/browse/JDK-8268463.

[krk]

/integrate

Thanks, will do.

[krk]

/integrate

[openjdk]

@krk
Your change (at version 9f252d8) is now ready to be sponsored by a Committer.

[openjdk]

@krk
Your change (at version 9f252d8) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 971e6dc.
Since your change was applied there have been 5 commits pushed to the master branch:

• 7ff53b5: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build
• 1468cfa: 8211328: Different declaration and definition of ClassLoaderData::classes_do() leads to build failures
• 646b6b5: 8360816: [11u] Use default value for ProgramFiles(x86) in GHA
• ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/501f90c4902e41ff8fd5fdbfb8fd694771496f5b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @krk Pushed as commit 971e6dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.