Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented May 23, 2025

This patch provides a workaround for a bug in the latest version of Cygwin. Only JDK 11 is affected; newer versions are not impacted because the makefiles were updated by JDK-8220383.

The issue is that:
ifneq ($(wildcard $(IMPORT_MODULES_CLASSES)/$(MODULE)), )
returns results even when IMPORT_MODULES_CLASSES is empty/unset. This causes the build to incorrectly search for a module like /jdk.crypto.ec/, which fails because the directory does not exist.

The fix is to first check whether IMPORT_MODULES_CLASSES is set. If it is, we define IMPORT_MODULE_DIR as $(IMPORT_MODULES_CLASSES)/$(MODULE) and use this property consistently throughout the build. This matches the approach introduced in JDK-8220383 for this codepath.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8357657 needs maintainer approval

Issue

  • JDK-8357657: [11u][windows] cannot stat '/jdk.crypto.ec/*': No such file or directory (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3035/head:pull/3035
$ git checkout pull/3035

Update a local copy of the PR:
$ git checkout pull/3035
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3035/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3035

View PR using the GUI difftool:
$ git pr show -t 3035

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3035.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2025

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Aug 12, 2025

/touch

@openjdk
Copy link

openjdk bot commented Aug 12, 2025

@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset.

@mrserb mrserb marked this pull request as ready for review September 24, 2025 19:44
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 24, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Oct 23, 2025

/keepalive

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants