Skip to content

8388706: PolynomialP256Bench::benchAssign regression after JDK-8355216 - #32047

Open
smemery wants to merge 5 commits into
openjdk:masterfrom
smemery:JDK-8388706
Open

8388706: PolynomialP256Bench::benchAssign regression after JDK-8355216#32047
smemery wants to merge 5 commits into
openjdk:masterfrom
smemery:JDK-8388706

Conversation

@smemery

@smemery smemery commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

This fix allows for more accurate comparisons between intrinsics and Java performance for P256 conditional set operations.
Before this fix, benchmarks showed a 53% regression for intrinsics vs. Java due to constant propagation and dead-code removal by C2. After this fix, only a 8% drop in performance is observed for intrinsics vs. Java.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8388706: PolynomialP256Bench::benchAssign regression after JDK-8355216 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32047/head:pull/32047
$ git checkout pull/32047

Update a local copy of the PR:
$ git checkout pull/32047
$ git pull https://git.openjdk.org/jdk.git pull/32047/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32047

View PR using the GUI difftool:
$ git pr show -t 32047

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32047.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 25, 2026

Copy link
Copy Markdown

👋 Welcome back semery! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 25, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the security security-dev@openjdk.org label Jul 25, 2026
@openjdk

openjdk Bot commented Jul 25, 2026

Copy link
Copy Markdown

@smemery The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 25, 2026
@mlbridge

mlbridge Bot commented Jul 25, 2026

Copy link
Copy Markdown

Webrevs

@smemery

smemery commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/label add hotspot-compiler

@openjdk openjdk Bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 28, 2026
@openjdk

openjdk Bot commented Jul 28, 2026

Copy link
Copy Markdown

@smemery
The hotspot-compiler label was successfully added.

@openjdk

openjdk Bot commented Jul 28, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant