8388810: Exceeding CachedRowSet max rows should only warn once by justin-curtis-lu · Pull Request #32033 · openjdk/jdk

justin-curtis-lu · 2026-07-23T21:41:20Z

Ensure that the implementation does not generate subsequent warnings for each row exceeded above the maximum allowed.

Additional fixes included

crs created via hashtable c-tor no longer throws NPE when its warning is referenced.
2-arg populate uses setWarning with a RowSetWarning which fixes the issue when the warning was polled by client and an Error occurred, because setException does not expect an SQLException
Root warning is no longer a pointless blank warning. The root warning now always contains a valid warning message.

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8388810: Exceeding CachedRowSet max rows should only warn once (Bug - P4)

Reviewers

Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32033/head:pull/32033
$ git checkout pull/32033

Update a local copy of the PR:
$ git checkout pull/32033
$ git pull https://git.openjdk.org/jdk.git pull/32033/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32033

View PR using the GUI difftool:
$ git pr show -t 32033

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32033.diff

Using Webrev

Link to Webrev Comment

justin-curtis-lu · 2026-07-23T21:42:14Z

        insertRow = null;
-
-        // set the warnings
-        sqlwarn = new SQLWarning();


sqlwarn does not get a addRowSetWarning style method because it is unused by the implementation.

bridgekeeper · 2026-07-23T21:42:29Z

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-07-23T21:42:42Z

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8388810: Exceeding CachedRowSet max rows should only warn once

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

e6f5c5d: 8388809: Shenandoah: Control thread may observe incorrect cancellation reason
a4e39d6: 8388443: C2: Assertion in PhaseRegAlloc::reg2offset() is too strict
e0f6001: 8388543: AArch64: VectorAPI: replace sve_dup+mov with fmovd in sve_vmask_fromlong
... and 47 more: https://git.openjdk.org/jdk/compare/b65f46d403be04a88f917585a9ad94b9825590b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

justin-curtis-lu · 2026-07-23T21:43:02Z

-                rowsetWarning.setNextException(new SQLException("Populating rows "
-                + "setting has exceeded max row setting"));
+            if (rowsFetched >= mRows && mRows > 0) {
+                addRowSetWarning(MAX_ROW_WARNING);


exceededMax is not required for the 2-arg populate because the existing code already breaks out of processing altogether when the max is encountered.

openjdk · 2026-07-23T21:43:24Z

@justin-curtis-lu The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

justin-curtis-lu · 2026-07-23T21:45:23Z

Added these warning tests as a standalone test file, since test/jdk/javax/sql/test/rowset/cachedrowset/CachedRowSetTests.java is better reserved for the common test suite.

justin-curtis-lu · 2026-07-23T21:47:22Z

+     */
+    private void addRowSetWarning(String reason) {
+        if (rowsetWarning == null) {
+            rowsetWarning = new RowSetWarning(reason);


Although I consider it a bug that the root warning was always empty in the original code, I can revert this change to the original behavior if we think there is risk.

This should be fine

mlbridge · 2026-07-23T21:55:49Z

Webrevs

00: Full (eb0ee96b)

LanceAndersen

Looks good Justin

LanceAndersen · 2026-07-24T15:45:13Z

+     */
+    private void addRowSetWarning(String reason) {
+        if (rowsetWarning == null) {
+            rowsetWarning = new RowSetWarning(reason);


This should be fine

justin-curtis-lu · 2026-07-27T16:21:20Z

/integrate

openjdk · 2026-07-27T16:22:58Z

Going to push as commit 79d629a.
Since your change was applied there have been 61 commits pushed to the master branch:

057985b: 8384807: Populate OMCache from C2
e8fdd54: 8388837: RISC-V: Track card addresses directly in G1 array post-write barrier loop
9ce3705: 8388072: Linux/AArch64 PAC-RET: assert(top.pc() == (address)(sp - frame::sender_sp_ret_address_offset())) failed
... and 58 more: https://git.openjdk.org/jdk/compare/b65f46d403be04a88f917585a9ad94b9825590b9...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-07-27T16:23:09Z

@justin-curtis-lu Pushed as commit 79d629a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

justin-curtis-lu added 2 commits July 23, 2026 14:32

Add test

46c215c

Impl fixes

eb0ee96

justin-curtis-lu commented Jul 23, 2026

View reviewed changes

openjdk Bot added the core-libs core-libs-dev@openjdk.org label Jul 23, 2026

justin-curtis-lu commented Jul 23, 2026

View reviewed changes

justin-curtis-lu changed the title ~~8388810: Exceeding CachedRowSet max rows should warn once~~ 8388810: Exceeding CachedRowSet max rows should only warn once Jul 23, 2026

justin-curtis-lu marked this pull request as ready for review July 23, 2026 21:51

openjdk Bot added the rfr Pull request is ready for review label Jul 23, 2026

LanceAndersen approved these changes Jul 24, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Jul 24, 2026

openjdk Bot added the integrated Pull request has been integrated label Jul 27, 2026

openjdk Bot closed this Jul 27, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 27, 2026

Uh oh!

Conversation

justin-curtis-lu commented Jul 23, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

justin-curtis-lu Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

bridgekeeper Bot commented Jul 23, 2026

Uh oh!

openjdk Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justin-curtis-lu Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

openjdk Bot commented Jul 23, 2026

Uh oh!

justin-curtis-lu Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LanceAndersen Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

mlbridge Bot commented Jul 23, 2026

Webrevs

Uh oh!

LanceAndersen left a comment

Choose a reason for hiding this comment

Uh oh!

LanceAndersen Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu commented Jul 27, 2026

Uh oh!

openjdk Bot commented Jul 27, 2026

Uh oh!

openjdk Bot commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

justin-curtis-lu commented Jul 23, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Jul 23, 2026 •

edited

Loading

justin-curtis-lu Jul 23, 2026 •

edited

Loading